Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased height of proxy authentication dialog to prevent cutting confirmation buttons #83900

Merged
merged 3 commits into from
Sep 8, 2020
Merged

Increased height of proxy authentication dialog to prevent cutting confirmation buttons #83900

merged 3 commits into from
Sep 8, 2020

Conversation

mbassit
Copy link
Contributor

@mbassit mbassit commented Nov 4, 2019 •
edited

This PR fixes #83899

VSCode_ProxyDialogIssueFixed

@mbassit mbassit marked this pull request as ready for review November 4, 2019 00:40
@chrmarti chrmarti assigned joaomoreno and unassigned chrmarti Nov 4, 2019
@joaomoreno joaomoreno added linux Issues with VS Code on Linux ux User experience issues and removed linux Issues with VS Code on Linux labels Nov 4, 2019
@joaomoreno joaomoreno added this to the September 2020 milestone Sep 8, 2020
@joaomoreno
Copy link
Member

Thanks!

@joaomoreno joaomoreno merged commit 4a801b9 into microsoft:master Sep 8, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@diguifi diguifi diguifi approved these changes

Assignees

@joaomoreno joaomoreno

Labels
ux User experience issues
Projects
None yet
Milestone
September 2020
Development

Successfully merging this pull request may close these issues.

Proxy authentication dialog cuts confirmation buttons
4 participants
@mbassit @joaomoreno @diguifi @chrmarti